packaging: build and bundle UI using npm in deb and rpm packages by yadvr · Pull Request #4605 · apache/cloudstack

yadvr · 2021-01-20T16:52:27Z

This changes deb and rpm packaging to build the UI using npm and bundle
it in the cloudstack-management package and a new cloudstack-ui
package. The cloudstack-ui package will install the UI under
/usr/share/cloudstack-ui/. For both packages the config.json will not
be overridden on upgrade.

This changes deb and rpm packaging to build the UI using npm and bundle it in the `cloudstack-management` package and a new `cloudstack-ui` package. The `cloudstack-ui` package will install the UI under `/usr/share/cloudstack-ui/`. For both packages the config.json will not be overridden on upgrade. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2021-01-20T16:52:39Z

@blueorangutan package

blueorangutan · 2021-01-20T16:53:41Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

blueorangutan · 2021-01-20T17:45:05Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2558

yadvr · 2021-01-20T17:46:07Z

@blueorangutan test

blueorangutan · 2021-01-20T17:46:36Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-01-20T17:49:48Z

Packages screenshot for file confirmation:

wido · 2021-01-20T18:02:19Z

debian/rules


+	# cloudstack-ui
+	mkdir -p $(DESTDIR)/usr/share/$(PACKAGE)-ui
+	cd ui && npm install && npm run build && cd ..


This assumes that npn is available on the system. However, that's not a guarantee.

The .deb (and .rpm) should have a build depends on 'npm'

Yes that adds a dependency much like jdk or mvn. I've added nodejs-12 (lts) in the container images that are used to build packages by blueorangutan. https://hub.docker.com/u/bhaisaab

The problem is that nodejs may not be available in default/main repo of the distros. Should we document it on docs and install.md?

@rhtyd this looks like a good point to be documented indeed

The problem is that nodejs may not be available in default/main repo of the distros. Should we document it on docs and install.md?

No, we should require it in the .spec and control file as a hard requirement. The build will fail without those, so it shouldn't even start to build.

The control and .spec file should exactly specify what is needed to build the packages. Without those dependencies the build should not initiate

Added, but that won't be satisfied automatically chances are somebody will install older version of nodejs.

blueorangutan · 2021-01-21T05:42:52Z

Trillian test result (tid-3403)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41304 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4605-t3403-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	123.82	test_kubernetes_clusters.py

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2021-01-21T12:34:07Z

@wido @GabrielBrascher doc PR raised here: apache/cloudstack-documentation#182 and I've updated INSTALL.md in this PR
@blueorangutan package

blueorangutan · 2021-01-21T12:34:39Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-01-21T16:41:11Z

Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2567

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2021-01-21T21:16:18Z

@blueorangutan package

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2021-01-21T21:21:58Z

@blueorangutan package

blueorangutan · 2021-01-21T21:22:47Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2021-01-21T21:30:21Z

@blueorangutan package

yadvr · 2021-01-23T00:11:07Z

@blueorangutan package

blueorangutan · 2021-01-23T00:11:51Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-01-23T00:51:53Z

Packaging result: ✔centos7 ✔centos8 ✖debian. JID-2575

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2021-01-25T06:52:12Z

@blueorangutan package

blueorangutan · 2021-01-25T06:53:01Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2021-01-25T12:41:42Z

@blueorangutan package

blueorangutan · 2021-01-25T12:43:14Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-01-25T13:56:20Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2589

yadvr · 2021-01-27T10:00:02Z

@blueorangutan test

blueorangutan · 2021-01-27T10:01:05Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-01-27T10:18:38Z

@weizhouapache I've build/scp-ed the packages here if you want to review/test http://download.cloudstack.org/testing/pr-4605/

weizhouapache · 2021-01-27T10:25:21Z

@weizhouapache I've build/scp-ed the packages here if you want to review/test http://download.cloudstack.org/testing/pr-4605/

@rhtyd thanks, I will test it.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Pearl1594 · 2021-01-27T12:48:44Z

@blueorangutan package

blueorangutan · 2021-01-27T12:50:11Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2021-01-27T12:56:13Z

Aborted previous build job, kicking new one
@blueorangutan package

blueorangutan · 2021-01-27T12:57:06Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

weizhouapache · 2021-01-27T13:14:31Z

@weizhouapache I've build/scp-ed the packages here if you want to review/test http://download.cloudstack.org/testing/pr-4605/

@rhtyd thanks, I will test it.

@rhtyd
waiting for new packages on http://download.cloudstack.org/testing/pr-4605/debian/

Not Found
The requested URL was not found on this server.

Apache/2.4.18 (Ubuntu) Server at download.cloudstack.org Port 80

blueorangutan · 2021-01-27T13:40:37Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2602

yadvr · 2021-01-27T13:41:25Z

@weizhouapache yes the pkgs just got rebuilt, I'll sync in next 15mins and ping you.

yadvr · 2021-01-27T13:51:34Z

@weizhouapache synced now http://download.cloudstack.org/testing/pr-4605/

Pearl1594

Tested. LGTM

yadvr · 2021-01-28T08:01:24Z

@weizhouapache we've two LGTMs, are you testing this? Thanks.

weizhouapache · 2021-01-28T08:29:28Z

@weizhouapache we've two LGTMs, are you testing this? Thanks.

@rhtyd yes, tested ok. reviewing code. I will get back to you in 30 min.

weizhouapache

lgtm

tested ok on ubuntu.

the only concern is, primate ui is shipped with cloudstack-management as well. if cloudstack-management and cloudstack-ui are both installed, the following two folder have same code.

/usr/share/cloudstack-management/webapp
/usr/share/cloudstack-ui

They use same config /etc/cloudstack/ui/config.json, I think it is not a major issue.

yadvr added component:packaging component:UI labels Jan 20, 2021

yadvr added this to the 4.15.1.0 milestone Jan 20, 2021

yadvr requested review from GabrielBrascher, davidjumani, weizhouapache and wido January 20, 2021 16:52

include legacy dir on 4.15

0303504

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

wido reviewed Jan 20, 2021

View reviewed changes

yadvr added 2 commits January 21, 2021 17:53

add nodejs as new dependency

be8839a

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

travis nodejs lts install

b5a92d6

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

pom: bump depedency versions to address cve issue

f06445b

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr force-pushed the new-ui-pkg branch from 53a6f94 to f06445b Compare January 21, 2021 21:15

fix build to include legacy dir

c6775b0

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

address wido's request

b668a9c

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix path issue

a0965c5

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr assigned Pearl1594 Jan 27, 2021

fix config symlink paths for centos pkgs

0d2258b

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

debian: fix ln -sf path

23c5dab

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Pearl1594 approved these changes Jan 28, 2021

View reviewed changes

weizhouapache approved these changes Jan 28, 2021

View reviewed changes

yadvr merged commit abec6d1 into apache:4.15 Jan 28, 2021

shwstppr mentioned this pull request Feb 10, 2021

CS-4.15: CentOS: Official New UI Missing in Packaging from Source #4680

Closed

Conversation

yadvr commented Jan 20, 2021

Uh oh!

yadvr commented Jan 20, 2021

Uh oh!

blueorangutan commented Jan 20, 2021

Uh oh!

blueorangutan commented Jan 20, 2021

Uh oh!

yadvr commented Jan 20, 2021

Uh oh!

blueorangutan commented Jan 20, 2021

Uh oh!

yadvr commented Jan 20, 2021

Uh oh!

wido Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GabrielBrascher Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

wido Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

yadvr Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 21, 2021

Uh oh!

yadvr commented Jan 21, 2021

Uh oh!

blueorangutan commented Jan 21, 2021

Uh oh!

blueorangutan commented Jan 21, 2021

Uh oh!

yadvr commented Jan 21, 2021

Uh oh!

yadvr commented Jan 21, 2021

Uh oh!

blueorangutan commented Jan 21, 2021

Uh oh!

yadvr commented Jan 21, 2021

Uh oh!

yadvr commented Jan 23, 2021

Uh oh!

blueorangutan commented Jan 23, 2021

Uh oh!

blueorangutan commented Jan 23, 2021

Uh oh!

yadvr commented Jan 25, 2021

Uh oh!

blueorangutan commented Jan 25, 2021

Uh oh!

yadvr commented Jan 25, 2021

Uh oh!

blueorangutan commented Jan 25, 2021

Uh oh!

blueorangutan commented Jan 25, 2021

Uh oh!

yadvr commented Jan 27, 2021

Uh oh!

blueorangutan commented Jan 27, 2021

Uh oh!

yadvr commented Jan 27, 2021

Uh oh!

weizhouapache commented Jan 27, 2021

Uh oh!

Pearl1594 commented Jan 27, 2021

Uh oh!

blueorangutan commented Jan 27, 2021

Uh oh!

yadvr commented Jan 27, 2021

Uh oh!

yadvr Jan 20, 2021 •

edited

Loading

weizhouapache left a comment •

edited

Loading